Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The application normally writes the process PID to
/MapRouletteAPI/RUNNING_PID, and refuses to start when that file exists (to ensure only a single copy is running at a time).However, this is annoying when running the backend in a container, where the orchestrator (Docker daemon, Kubernetes, etc) already ensures that only one instance is running per namespace. If the application crashes without cleaning up the RUNNING_PID file, then it will refuse to launch when the orchestrator restarts it. Depending on the deploy configuration, this may require a human to intervene by deleting the container before restarting the service.
To fix this, this PR makes the container image ignore the pidfile by default.